New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minhook: add minhook/cci.20240114 recipe #22165

Merged

conan-center-bot merged 5 commits into conan-io:master from wu-vincent:minhook_recipe

Jul 29, 2024

Contributor

wu-vincent commented Jan 5, 2024 •

edited

Loading

Specify library name and version: minhook/cci.20240114

minhook is a x86/x64 API Hooking Library for Windows. It is a lightweight alternative to the Detours library. Although I am not the original author, I believe creating a Conan recipe for this useful library will benefit the community with easier integration and broader usage.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant commented Jan 5, 2024 •

edited

Loading

All committers have signed the CLA.

conan-center-bot added the User-approval pending label

This comment has been minimized.

Sign in to view

2 similar comments

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added Failed and removed User-approval pending labels

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

conan-center-bot removed the Failed label

This comment has been minimized.

Sign in to view

AbrilRBS self-assigned this

Member

AbrilRBS commented Jan 5, 2024

Maybe we could ask the maintainers to also create a new release? The last one is from 2017!

Contributor Author

wu-vincent commented Jan 8, 2024 •

edited

Loading

Hi, thank you for your suggestion. I completely agree that having the latest releases in Conan Center is ideal for ensuring the most up-to-date and stable versions are available. Someone raised an issue back in April 2023 to request a new release. Unfortunately, there hasn't been a response from the maintainer yet.

In light of this, I propose creating a cci version of the package (e.g., minhook/cci.20240108). This would enable users to benefit from the recent improvements while we await an official release. This approach has been adopted for other libraries in similar situations, such as detours/cci.20220630.

I'd appreciate your thoughts on this approach or any alternative suggestions you might have.

wu-vincent force-pushed the minhook_recipe branch from 223ea76 to fd30a52 Compare

January 9, 2024 10:52

This comment has been minimized.

Sign in to view

Member

AbrilRBS commented Jan 11, 2024

@wu-vincent let's do that!

conan-center-bot requested a review from franramirez688

January 11, 2024 13:11

wu-vincent force-pushed the minhook_recipe branch from fc01f67 to 913b927 Compare

January 14, 2024 23:40

wu-vincent changed the title ~~minhook: add minhook/1.3.3 recipe~~ minhook: add minhook/cci.20240114 recipe


          minhook: add minhook/cci.20240114 recipe

6789bf1

wu-vincent force-pushed the minhook_recipe branch from 913b927 to 6789bf1 Compare

January 14, 2024 23:43

This comment has been minimized.

Sign in to view

conan-center-bot requested a review from AbrilRBS

February 8, 2024 11:41

valgur suggested changes

View reviewed changes

Contributor

valgur left a comment

LGTM. Just one minor change required.

recipes/minhook/all/patches/cci.20240114-0001-increase-cmake-min.patch Outdated Show resolved Hide resolved


          Update recipes/minhook/all/patches/cci.20240114-0001-increase-cmake-m…

f080976

…in.patch

Co-authored-by: Martin Valgur <[email protected]>

Contributor Author

wu-vincent commented Mar 24, 2024

@valgur Thank you for the suggestion! I've made the change accordingly.

This comment has been minimized.

Sign in to view

valgur approved these changes

View reviewed changes

ErniGH mentioned this pull request

Prioritization of new recipe PRs #24327

Open

perseoGI self-requested a review

July 4, 2024 10:45

memsharded reviewed

View reviewed changes

Member

memsharded left a comment

This is looking good, I'll try to give it a final push to get it merged.
Thanks for your contribution, and I apologize for the delays in reviewing, the load is simply overwhelming and prioritizing is very challenging.

recipes/minhook/all/conandata.yml Outdated

		@@ -0,0 +1,9 @@
		sources:
		"cci.20240114":

Member

memsharded Jul 29, 2024

We will be updating this versioning scheme, to be more future-proof. I'll do it myself and contribute.

memsharded self-assigned this

memsharded added 3 commits

July 29, 2024 17:53


          Merge branch 'master' into minhook_recipe

d9c22a8


          review and update to latest commit

29ecb65


          add config.yml changes

d40b30e

AbrilRBS approved these changes

View reviewed changes

Collaborator

conan-center-bot commented Jul 29, 2024

Conan v1 pipeline ✔️

All green in build 3 (d40b30ea894b911c5b0151dd52be2d47185ef029):

minhook/1.3.3.cci.20240629:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (d40b30ea894b911c5b0151dd52be2d47185ef029):

minhook/1.3.3.cci.20240629:
All packages built successfully! (All logs)

memsharded approved these changes

View reviewed changes

conan-center-bot merged commit de1245e into conan-io:master

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

memsharded memsharded approved these changes

AbrilRBS AbrilRBS approved these changes

valgur valgur approved these changes

franramirez688 Awaiting requested review from franramirez688

perseoGI Awaiting requested review from perseoGI

Labels

None yet